Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fallback field type when it isn't in request #33832

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix: Fallback field type when it isn't in request #33832

merged 1 commit into from
Jun 14, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #33432

@xiaocai2333 xiaocai2333 changed the title Fallback field type when it isn't in request fix: Fallback field type when it isn't in request Jun 13, 2024
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Jun 13, 2024

/approve
/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (08fcf3f) to head (b8e6a13).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33832      +/-   ##
==========================================
- Coverage   80.92%   80.89%   -0.03%     
==========================================
  Files        1058     1058              
  Lines      135395   135395              
==========================================
- Hits       109563   109524      -39     
- Misses      21655    21677      +22     
- Partials     4177     4194      +17
Files Coverage Δ
internal/indexnode/task_index.go 72.41% <100.00%> (-0.58%) ⬇️

... and 30 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Fallback field type when it isn't in request
b8e6a13 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Jun 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jun 13, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b69e909 into milvus-io:master Jun 14, 2024
15 checks passed
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Jun 24, 2024
xiaocai2333 added a commit to xiaocai2333/milvus that referenced this pull request Jun 25, 2024
@xiaocai2333
fix: Fallback field type when it isn't in request (milvus-io#33832)
5478c5c 
issue: milvus-io#33432

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 mentioned this pull request Jun 25, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Jun 25, 2024
@xiaocai2333
fix: [pick] Fallback field type when it isn't in request (#33832) (#3…
65050b3 
…4133)

issue: #33432
pr: #33832

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
xiaocai2333 added a commit to xiaocai2333/milvus that referenced this pull request Jul 1, 2024
@xiaocai2333
fix: Fallback field type when it isn't in request (milvus-io#33832)
578a402 
issue: milvus-io#33432

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
xiaocai2333 added a commit to xiaocai2333/milvus that referenced this pull request Jul 1, 2024
@xiaocai2333
fix: Fallback field type when it isn't in request (milvus-io#33832)
213e99d 
issue: milvus-io#33432

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 mentioned this pull request Jul 1, 2024
Merged
czs007 pushed a commit that referenced this pull request Jul 2, 2024
@xiaocai2333 @chasingegg @PwzXxm
enhance: [cherry-pick] Refine index code and support analyze data (#3…
c924b0b 
…4311)

This PR primary picks up the support analyzing functionality, including
the following commits:
- main functionality: #33651
- refine indexnode code: #33458
- related fixes:
  - #33832
  - #33161

issue: #30633 
master prs: #33651 , #33458 , #33832 , #33161

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
Co-authored-by: chasingegg <chao.gao@zilliz.com>
Co-authored-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
@czs007 czs007 removed the PR | need cherry-pick need cherry pick to other branches label Jul 2, 2024
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@xiaocai2333 @yellow-shine
fix: Fallback field type when it isn't in request (milvus-io#33832)
dbf7c7c 
issue: milvus-io#33432

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 deleted the fallback_field_type branch July 9, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xiaocai2333 @czs007 @xiaofan-luan @sre-ci-robot