Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [pick] Fallback field type when it isn't in request (#33832) #34133

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented Jun 25, 2024

issue: #33432
pr: #33832

issue: milvus-io#33432

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 25, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jun 25, 2024
Copy link
Contributor

mergify bot commented Jun 25, 2024

@xiaocai2333 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.72%. Comparing base (1168e8c) to head (5478c5c).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34133      +/-   ##
==========================================
- Coverage   81.83%   81.72%   -0.12%     
==========================================
  Files        1005     1012       +7     
  Lines      130111   129748     -363     
==========================================
- Hits       106479   106035     -444     
- Misses      19644    19697      +53     
- Partials     3988     4016      +28     
Files Coverage Δ
internal/indexnode/task.go 55.55% <37.50%> (+0.11%) ⬆️

... and 238 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jun 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants