Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readd timestamp index because segment timestamp not ordered #33856

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

zhagnlu
Copy link
Collaborator

@zhagnlu zhagnlu commented Jun 14, 2024

Signed-off-by: luzhang <luzhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (9d4535c) to head (bb9bc9a).
Report is 26 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33856      +/-   ##
==========================================
+ Coverage   80.91%   81.00%   +0.08%     
==========================================
  Files        1058     1050       -8     
  Lines      135193   135600     +407     
==========================================
+ Hits       109397   109841     +444     
+ Misses      21613    21577      -36     
+ Partials     4183     4182       -1     
Files Coverage Δ
internal/core/src/segcore/InsertRecord.h 91.01% <100.00%> (-0.17%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.cpp 75.87% <77.27%> (+0.53%) ⬆️

... and 237 files with indirect coverage changes

sre-ci-robot pushed a commit that referenced this pull request Jun 14, 2024
)

pr: #33856

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Jun 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 16, 2024
@sre-ci-robot sre-ci-robot merged commit e422168 into milvus-io:master Jun 16, 2024
14 of 15 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
…vus-io#33856)

milvus-io#33533

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants