enhance: Rename Compaction to CompactionV2 #33858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
mergify
bot
added
dco-passed
|
test result:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33858 +/- ##
==========================================
- Coverage 80.92% 80.91% -0.01%
==========================================
Files 1058 1058
Lines 135395 135395
==========================================
- Hits 109562 109556 -6
+ Misses 21656 21648 -8
- Partials 4177 4191 +14
|
8 tasks
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bigsheeper
added a commit
to bigsheeper/milvus
that referenced
this pull request
Jun 25, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jun 25, 2024
This PR cherry-picks the following commits: - Implement task limit control logic in datanode. #32881 - Load bf from storage instead of memory during L0 compaction. #32913 - Remove dependencies on shards (e.g. SyncSegments, injection). #33138 - Rename Compaction interface to CompactionV2. #33858 - Remove the unused residual compaction logic. #33932 issue: #32809 pr: #32881, #32913, #33138, #33858, #33932 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this pull request
Jul 2, 2024
Due to the removal of injection and syncSegments from the compaction, we need to ensure that no compaction is successfully executed during the rolling upgrade. This PR renames Compaction to CompactionV2, with the following effects: - New datacoord + old datanode: Utilizes the CompactionV2 interface, resulting in the datanode error "CompactionV2 not implemented," causing compaction to fail; - Old datacoord + new datanode: Utilizes the CompactionV1 interface, resulting in the datanode error "CompactionV1 not implemented," causing compaction to fail. issue: milvus-io#32809 Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the removal of injection and syncSegments from the compaction, we need to ensure that no compaction is successfully executed during the rolling upgrade. This PR renames Compaction to CompactionV2, with the following effects:
issue: #32809