Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: move rocksmq from internal to pkg module #33881

Merged
merged 1 commit into from
Jun 25, 2024
Merged

enhance: move rocksmq from internal to pkg module #33881

merged 1 commit into from
Jun 25, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jun 14, 2024 •
edited
Loading

issue: #33956

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file labels Jun 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024

@jaime0815 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@jaime0815 jaime0815 force-pushed the remove-rocksmq-to-pkg branch 2 times, most recently from f4e3b58 to bc3df4d Compare June 17, 2024 11:39
@codecov Codecov
Copy link

codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.64286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (b460862) to head (6fcb2b1).
Report is 70 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33881      +/-   ##
==========================================
- Coverage   81.01%   80.99%   -0.03%     
==========================================
  Files        1054     1076      +22     
  Lines      136218   137162     +944     
==========================================
+ Hits       110359   111095     +736     
- Misses      21688    21843     +155     
- Partials     4171     4224      +53
Files Coverage Δ
internal/allocator/global_id_allocator.go 80.00% <ø> (-10.00%) ⬇️
internal/datacoord/channel_checker.go 95.83% <ø> (ø)
internal/datacoord/channel_manager.go 76.40% <ø> (ø)
internal/datacoord/channel_manager_v2.go 87.32% <ø> (+0.05%) ⬆️
internal/datacoord/channel_store.go 78.43% <ø> (ø)
internal/datacoord/channel_store_v2.go 81.64% <ø> (ø)
internal/datacoord/server.go 71.83% <100.00%> (-0.31%) ⬇️
internal/datanode/data_node.go 82.20% <ø> (ø)
internal/datanode/event_manager.go 80.16% <ø> (ø)
...nternal/datanode/flow_graph_dmstream_input_node.go 93.54% <100.00%> (ø)
... and 56 more

... and 355 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 18, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jun 18, 2024
@jaime0815 jaime0815 changed the title enhance: remove rocksmq from internal to pkg module enhance: move rocksmq from internal to pkg module Jun 19, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Jun 19, 2024
@jaime0815 jaime0815 mentioned this pull request Jun 21, 2024
Open
40 tasks
@jaime0815
enhance: remove rocksmq from internal to pkg
6fcb2b1 
Signed-off-by: jaime <yun.zhang@zilliz.com>
@mergify mergify bot removed the ci-passed label Jun 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815 jaime0815 mentioned this pull request Jun 25, 2024
Merged
@czs007
Copy link
Contributor

czs007 commented Jun 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jun 25, 2024
@sre-ci-robot sre-ci-robot merged commit 9630974 into milvus-io:master Jun 25, 2024
12 checks passed
@jaime0815 jaime0815 deleted the remove-rocksmq-to-pkg branch June 26, 2024 03:31
sre-ci-robot pushed a commit that referenced this pull request Jun 26, 2024
@jaime0815
enhance: move rocksmq from internal to pkg (#34165)
6423b6c 
pr:  #33881
issue:  #33956

Signed-off-by: jaime <yun.zhang@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@jaime0815 @yellow-shine
enhance: move rocksmq from internal to pkg module (milvus-io#33881)
eb83d37 
issue: milvus-io#33956

Signed-off-by: jaime <yun.zhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@czs007 czs007

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaime0815 @czs007 @sre-ci-robot