Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: move rocksmq from internal to pkg #34165

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jun 25, 2024

pr: #33881
issue: #33956

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Jun 25, 2024
@sre-ci-robot sre-ci-robot requested a review from aoiasd June 25, 2024 12:05
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jun 25, 2024
Copy link
Contributor

mergify bot commented Jun 25, 2024

@jaime0815 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jun 25, 2024
Copy link
Contributor

mergify bot commented Jun 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jun 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

jaime0815 commented Jun 25, 2024

pr: #33881

Copy link
Contributor

mergify bot commented Jun 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: jaime <yun.zhang@zilliz.com>
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 94.64286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.98%. Comparing base (3ae1865) to head (f69f067).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34165      +/-   ##
==========================================
- Coverage   82.08%   81.98%   -0.10%     
==========================================
  Files        1016     1012       -4     
  Lines      130208   130227      +19     
==========================================
- Hits       106882   106773     -109     
- Misses      19323    19466     +143     
+ Partials     4003     3988      -15     
Files Coverage Δ
internal/allocator/global_id_allocator.go 80.00% <ø> (-10.00%) ⬇️
internal/datacoord/channel_checker.go 95.83% <ø> (ø)
internal/datacoord/channel_manager.go 75.88% <ø> (-1.38%) ⬇️
internal/datacoord/channel_manager_v2.go 85.74% <ø> (ø)
internal/datacoord/channel_store.go 77.51% <ø> (ø)
internal/datacoord/channel_store_v2.go 80.73% <ø> (ø)
internal/datacoord/server.go 71.47% <100.00%> (-0.16%) ⬇️
internal/datanode/data_node.go 82.20% <ø> (ø)
internal/datanode/event_manager.go 80.16% <ø> (ø)
...nternal/datanode/flow_graph_dmstream_input_node.go 93.54% <100.00%> (ø)
... and 56 more

... and 166 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 26, 2024
@jaime0815 jaime0815 changed the title enhance: remove rocksmq from internal to pkg enhance: move rocksmq from internal to pkg Jun 26, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Jun 26, 2024
@czs007
Copy link
Contributor

czs007 commented Jun 26, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6423b6c into milvus-io:2.4 Jun 26, 2024
12 checks passed
@jaime0815 jaime0815 deleted the remove-rocksmq-to-pkg-24 branch June 26, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants