Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix l0 compaction may miss some sealed segments #33980

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jun 19, 2024

issue: #33955

issue: milvus-io#33955

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 19, 2024
@XuanYang-cn
Copy link
Contributor

/lgtm
@sunby Also needed on 2.4 branch

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (5fac2fa) to head (f4b2b85).
Report is 24 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33980      +/-   ##
==========================================
- Coverage   80.89%   80.88%   -0.02%     
==========================================
  Files        1063     1064       +1     
  Lines      136139   136243     +104     
==========================================
+ Hits       110136   110203      +67     
- Misses      21817    21838      +21     
- Partials     4186     4202      +16     
Files Coverage Δ
internal/datacoord/compaction_task_l0.go 61.08% <100.00%> (ø)

... and 16 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 19, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia congqixia added the PR | need cherry-pick need cherry pick to other branches label Jun 21, 2024
@sre-ci-robot sre-ci-robot merged commit 622be36 into milvus-io:master Jun 21, 2024
15 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@czs007 czs007 removed the PR | need cherry-pick need cherry pick to other branches label Jul 2, 2024
czs007 added a commit that referenced this pull request Jul 3, 2024
This PR cherry-picks the following commits related to data compaction:
- enhance: Refine compaction.
[#33982](#33982)
- fix l0 compaction may miss some sealed segments.
[#33838](#33980)

issue : #32939
#33955

pr : #33982

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants