-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: legacy code clean up #33838
Conversation
@shaoting-huang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@shaoting-huang E2e jenkins job failed, comment |
@shaoting-huang ut workflow job failed, comment |
/run-cpu-e2e |
rerun ut |
Hello shaoting-huang, you are not in the organization, so you do not have the permission to rerun the workflow, please contact |
@shaoting-huang ut workflow job failed, comment |
Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33838 +/- ##
==========================================
- Coverage 80.92% 80.91% -0.01%
==========================================
Files 1058 1058
Lines 135395 135367 -28
==========================================
- Hits 109562 109529 -33
+ Misses 21656 21655 -1
- Partials 4177 4183 +6
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, shaoting-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: milvus-io#33839 Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
issue: #33839