Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: legacy code clean up #33838

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Jun 13, 2024

issue: #33839

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue labels Jun 13, 2024
Copy link
Contributor

mergify bot commented Jun 13, 2024

@shaoting-huang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jun 13, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 13, 2024

@shaoting-huang ut workflow job failed, comment rerun ut can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@shaoting-huang
Copy link
Contributor Author

rerun ut

Copy link
Contributor

Hello shaoting-huang, you are not in the organization, so you do not have the permission to rerun the workflow, please contact @milvus-io/milvus-maintainers for help.

Copy link
Contributor

mergify bot commented Jun 14, 2024

@shaoting-huang ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (b69e909) to head (aca856d).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33838      +/-   ##
==========================================
- Coverage   80.92%   80.91%   -0.01%     
==========================================
  Files        1058     1058              
  Lines      135395   135367      -28     
==========================================
- Hits       109562   109529      -33     
+ Misses      21656    21655       -1     
- Partials     4177     4183       +6     
Files Coverage Δ
internal/storage/binlog_iterator.go 92.50% <ø> (ø)
internal/storage/data_codec.go 69.66% <ø> (ø)
internal/storage/utils.go 80.76% <ø> (-0.41%) ⬇️

... and 33 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 14, 2024
@sunby
Copy link
Contributor

sunby commented Jun 14, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0ecd694 into milvus-io:master Jun 14, 2024
15 checks passed
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Jun 26, 2024
@mergify mergify bot removed the ci-passed label Jun 26, 2024
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
issue: milvus-io#33839

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
@czs007 czs007 removed the PR | need cherry-pick need cherry pick to other branches label Jul 2, 2024
@mergify mergify bot added the ci-passed label Jul 2, 2024
czs007 added a commit that referenced this pull request Jul 3, 2024
This PR cherry-picks the following commits related to data compaction:
- enhance: Refine compaction.
[#33982](#33982)
- fix l0 compaction may miss some sealed segments.
[#33838](#33980)

issue : #32939
#33955

pr : #33982

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jul 4, 2024
This PR cherry-picks the following commits related to data codec
- Fix data codec writer close. #33818
- Legacy code clean up. #33838

issue: #33813 #33839 

pr: #33818 #33838

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants