-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add delta log stream new format reader and writer #34116
Conversation
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34116 +/- ##
==========================================
- Coverage 80.86% 80.64% -0.23%
==========================================
Files 1094 1117 +23
Lines 137817 138814 +997
==========================================
+ Hits 111447 111941 +494
- Misses 22142 22605 +463
- Partials 4228 4268 +40
|
9f76b94
to
09b1394
Compare
|
87604a5
to
6bb784b
Compare
@shaoting-huang E2e jenkins job failed, comment |
https://iceberg.apache.org/spec/ wondering should we just follow iceberg standard |
bc88066
to
76cf96a
Compare
519ac3e
to
92fe0de
Compare
@shaoting-huang E2e jenkins job failed, comment |
92fe0de
to
c288f64
Compare
d0bd06c
to
c9e4df0
Compare
c9e4df0
to
6e7b993
Compare
6e7b993
to
a8d9d05
Compare
Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
a8d9d05
to
f4c6a46
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaoting-huang, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #34123
Benchmark case: The benchmark run the go benchmark function
BenchmarkDeltalogFormat
which is put in the Files changed. It tests the performance of serializing and deserializing from two different data formats under a 10 million delete log dataset.Metrics: The benchmarks measure the average time taken per operation (ns/op), memory allocated per operation (MB/op), and the number of memory allocations per operation (allocs/op).
Both read and write operations show significant improvements in both speed and memory allocation.