Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refine error message for invalid limit parameter #34178

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jaime0815
Copy link
Contributor

No description provided.

Signed-off-by: jaime <yun.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 26, 2024
Copy link
Contributor

mergify bot commented Jun 26, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (a77e295) to head (69ff04d).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34178      +/-   ##
==========================================
- Coverage   80.99%   79.85%   -1.14%     
==========================================
  Files        1076     1076              
  Lines      137183   137189       +6     
==========================================
- Hits       111109   109556    -1553     
- Misses      21842    23418    +1576     
+ Partials     4232     4215      -17     
Files Coverage Δ
internal/proxy/util.go 89.83% <100.00%> (ø)
internal/proxy/search_util.go 84.35% <66.66%> (ø)

... and 111 files with indirect coverage changes

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Contributor

czs007 commented Jun 26, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Jun 26, 2024
pr: #34178

Signed-off-by: jaime <yun.zhang@zilliz.com>
@mergify mergify bot added the ci-passed label Jun 26, 2024
@sre-ci-robot sre-ci-robot merged commit 9c2eeff into milvus-io:master Jun 26, 2024
12 checks passed
@jaime0815 jaime0815 deleted the rf-err-msg-m branch June 27, 2024 06:30
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants