Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DataNode might OOM by estimating based on MemorySize #34203

Merged
merged 5 commits into from
Jul 4, 2024

Merge remote-tracking branch 'upstream/2.4' into cp24/fix-estimation

26b2dfd
Select commit
Loading
Failed to load commit list.
Merged

fix: DataNode might OOM by estimating based on MemorySize #34203

Merge remote-tracking branch 'upstream/2.4' into cp24/fix-estimation
26b2dfd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 2, 2024 in 0s

72.53% (target 77.00%)

View this Pull Request on Codecov

72.53% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.53%. Comparing base (fc6bd38) to head (26b2dfd).
Report is 18 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34203      +/-   ##
==========================================
- Coverage   81.82%   72.53%   -9.30%     
==========================================
  Files        1010     1010              
  Lines      130787   130968     +181     
==========================================
- Hits       107021    94999   -12022     
- Misses      19766    31959   +12193     
- Partials     4000     4010      +10     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.38% <100.00%> (+<0.01%) ⬆️
internal/datanode/compaction/l0_compactor.go 91.86% <92.59%> (-0.73%) ⬇️

... and 226 files with indirect coverage changes