Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: use configed max topk for iterator when input topk exceeds #34290

Merged
merged 1 commit into from
Jul 4, 2024
Merged

enhance: use configed max topk for iterator when input topk exceeds #34290

merged 1 commit into from
Jul 4, 2024

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Jul 1, 2024 •
edited
Loading

related: #34290

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 1, 2024
@MrPresent-Han MrPresent-Han mentioned this pull request Jul 1, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 1, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (23e2a0e) to head (931a0de).
Report is 4 commits behind head on master.

❗ Current head 931a0de differs from pull request most recent head 0812bbd

Please upload reports for the commit 0812bbd to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34290      +/-   ##
==========================================
- Coverage   84.31%   80.89%   -3.42%     
==========================================
  Files         825     1095     +270     
  Lines      113633   137836   +24203     
==========================================
+ Hits        95809   111506   +15697     
- Misses      13601    22124    +8523     
+ Partials     4223     4206      -17
Files Coverage Δ
internal/proxy/search_util.go 84.61% <100.00%> (+0.25%) ⬆️

... and 319 files with indirect coverage changes

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 1, 2024
@mergify mergify bot removed the ci-passed label Jul 2, 2024
@MrPresent-Han
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@MrPresent-Han
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Jul 4, 2024
@MrPresent-Han
enhance: use configed max topk for iterator when input topk exceeds(#…
014cb7b 
…34292) (#34293)

related: #34292
pr: #34290

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
@mergify mergify bot added the ci-passed label Jul 4, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 10b3ce2 into milvus-io:master Jul 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrPresent-Han @czs007 @sre-ci-robot