enhance: use configed max topk for iterator when input topk exceeds(#34292) #34293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
MrPresent-Han
force-pushed
the
refine-topk-handling-2.4
branch
from
f7df327
to
8a7bf17
Compare
MrPresent-Han
force-pushed
the
refine-topk-handling-2.4
branch
from
8a7bf17
to
be2af71
Compare
|
@MrPresent-Han E2e jenkins job failed, comment |
|
/run-cpu-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #34293 +/- ##
==========================================
- Coverage 84.47% 81.02% -3.45%
==========================================
Files 776 1034 +258
Lines 111721 134836 +23115
==========================================
+ Hits 94379 109255 +14876
- Misses 13143 21380 +8237
- Partials 4199 4201 +2
|
|
/run-cpu-e2e |
…ilvus-io#34292) Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han
force-pushed
the
refine-topk-handling-2.4
branch
from
be2af71
to
047073f
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, MrPresent-Han The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #34292
pr: #34290