Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance:[Cherry-Pick] change access log write cache default config #34352

Merged
merged 1 commit into from
Jul 3, 2024
Merged

enhance:[Cherry-Pick] change access log write cache default config #34352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion configs/milvus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@ proxy:
localPath: /tmp/milvus_access
filename: # Log filename, leave empty to use stdout.
maxSize: 64 # Max size for a single file, in MB.
cacheSize: 10240 # Size of log of memory cache, in B
cacheSize: 0 # Size of log write cache, in B
cacheFlushInterval: 3 # time interval of auto flush write cache, in Seconds. (Close auto flush if interval was 0)
rotatedTime: 0 # Max time for single access log file in seconds
remotePath: access_log/ # File path in minIO
remoteMaxTime: 0 # Max time for log file in minIO, in hours
Expand Down
8 changes: 4 additions & 4 deletions pkg/util/paramtable/component_param.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,17 +1296,17 @@ please adjust in embedded Milvus: false`,
p.AccessLog.CacheSize = ParamItem{
Key: "proxy.accessLog.cacheSize",
Version: "2.3.2",
DefaultValue: "10240",
Doc: "Size of log of memory cache, in B. (Close write cache if szie was 0",
DefaultValue: "0",
Doc: "Size of log of write cache, in B. (Close write cache if size was 0",
Export: true,
}
p.AccessLog.CacheSize.Init(base.mgr)

p.AccessLog.CacheFlushInterval = ParamItem{
Key: "proxy.accessLog.cacheSize",
Key: "proxy.accessLog.cacheFlushInterval",
Version: "2.4.0",
DefaultValue: "3",
Doc: "time interval of auto flush memory cache, in Seconds. (Close auto flush if interval was 0)",
Doc: "time interval of auto flush write cache, in Seconds. (Close auto flush if interval was 0)",
}
p.AccessLog.CacheFlushInterval.Init(base.mgr)

Expand Down
Loading