Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance:change access log write cache default config #34354

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Jul 2, 2024

No description provided.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 2, 2024
Copy link
Contributor

mergify bot commented Jul 2, 2024

⚠️ The sha of the head commit of this PR conflicts with #34285. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (ba04981) to head (311aaae).
Report is 31 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34354      +/-   ##
==========================================
+ Coverage   79.70%   84.37%   +4.67%     
==========================================
  Files        1119      848     -271     
  Lines      138783   114425   -24358     
==========================================
- Hits       110614    96548   -14066     
+ Misses      23926    13636   -10290     
+ Partials     4243     4241       -2     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.48% <100.00%> (-0.01%) ⬇️

... and 294 files with indirect coverage changes

@aoiasd aoiasd force-pushed the C8 branch 2 times, most recently from ea003ca to 49e6cf9 Compare July 3, 2024 06:11
Copy link
Contributor

mergify bot commented Jul 3, 2024

@aoiasd Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/enhancement Issues or changes related to enhancement dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jul 3, 2024
@aoiasd
Copy link
Contributor Author

aoiasd commented Jul 3, 2024

rerun_ut

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c1e0453 into milvus-io:master Jul 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants