Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Cherry-pick]Pick major compaction fixs and optimizations #34360

Merged
merged 9 commits into from
Jul 3, 2024

Use new stream segment reader in clustering compaction (#34232)

a72b9bb
Select commit
Loading
Failed to load commit list.
Merged

fix: [Cherry-pick]Pick major compaction fixs and optimizations #34360

Use new stream segment reader in clustering compaction (#34232)
a72b9bb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 3, 2024 in 0s

80.76% (target 77.00%)

View this Pull Request on Codecov

80.76% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 69.23077% with 56 lines in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (7ee4ccb) to head (a72b9bb).
Report is 9 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34360      +/-   ##
==========================================
- Coverage   81.46%   80.76%   -0.70%     
==========================================
  Files        1028     1034       +6     
  Lines      132427   134672    +2245     
==========================================
+ Hits       107879   108766     +887     
- Misses      20474    21714    +1240     
- Partials     4074     4192     +118     
Files Coverage Δ
internal/datacoord/compaction_task_clustering.go 47.72% <100.00%> (ø)
internal/datanode/compaction/segment_writer.go 84.55% <100.00%> (+0.79%) ⬆️
internal/proxy/impl.go 86.19% <100.00%> (+<0.01%) ⬆️
internal/proxy/task.go 87.70% <100.00%> (-0.03%) ⬇️
internal/querycoordv2/checkers/balance_checker.go 95.12% <100.00%> (ø)
internal/querycoordv2/task/task.go 97.70% <100.00%> (+0.01%) ⬆️
internal/querynodev2/delegator/delegator.go 86.87% <100.00%> (+0.21%) ⬆️
internal/storage/partition_stats.go 81.39% <100.00%> (+2.08%) ⬆️
internal/storage/serde.go 88.05% <100.00%> (+0.04%) ⬆️
pkg/common/map.go 100.00% <100.00%> (ø)
... and 9 more

... and 35 files with indirect coverage changes