Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Enable setting the replica number and resource group during collection creation #34403

Merged
merged 3 commits into from
Jul 10, 2024
Merged

enhance: Enable setting the replica number and resource group during collection creation #34403

merged 3 commits into from
Jul 10, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #30040

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file area/test sig/testing test/integration integration test labels Jul 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 4, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.39%. Comparing base (314f4d9) to head (97a61b9).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34403      +/-   ##
==========================================
+ Coverage   84.36%   84.39%   +0.03%     
==========================================
  Files         858      858              
  Lines      115102   115145      +43     
==========================================
+ Hits        97104    97175      +71     
+ Misses      13711    13687      -24     
+ Partials     4287     4283       -4
Files Coverage Δ
tests/integration/util_collection.go 100.00% <100.00%> (ø)
internal/querycoordv2/meta/coordinator_broker.go 91.28% <91.66%> (+1.73%) ⬆️
internal/querycoordv2/services.go 86.23% <66.66%> (-0.70%) ⬇️
pkg/common/common.go 79.41% <78.94%> (-0.19%) ⬇️

... and 31 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Jul 5, 2024
@bigsheeper
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot removed the lgtm label Jul 8, 2024
@mergify mergify bot removed the ci-passed label Jul 8, 2024
@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Jul 9, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Jul 9, 2024
@weiliu1031
Copy link
Contributor Author

/hold

@jaime0815 jaime0815 mentioned this pull request Jul 9, 2024
Closed
1 task
@weiliu1031
enhance: Enable setting the replica number and resource group during …
e42dcec 
…collection creation

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031
fix ut
c6cd4fc 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031
update milvus-proto dependency
97a61b9 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@mergify mergify bot removed the ci-passed label Jul 9, 2024
@weiliu1031 weiliu1031 changed the title enhance: Enable setting the replica number and resource group during database creation Enable setting the replica number and resource group during collection creation Jul 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

@weiliu1031

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@weiliu1031
Copy link
Contributor Author

/unhold

@weiliu1031 weiliu1031 changed the title Enable setting the replica number and resource group during collection creation enhance: Enable setting the replica number and resource group during collection creation Jul 9, 2024
@bigsheeper
Copy link
Contributor

/lgtm

congqixia
congqixia approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9b37d3f into milvus-io:master Jul 10, 2024
12 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Jul 10, 2024
@weiliu1031
enhance: Enable setting the replica number and resource group during …
ef2fe42 
…collection creation (milvus-io#34403)

issue: milvus-io#30040

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper bigsheeper left review comments

@congqixia congqixia congqixia approved these changes

Assignees

@bigsheeper bigsheeper

@congqixia congqixia

Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weiliu1031 @bigsheeper @sre-ci-robot @congqixia