Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enable setting the replica number and resource group during collection creation (#34403) #34561

Merged

Conversation

weiliu1031
Copy link
Contributor

issue: #30040
pr: #34403


…collection creation (milvus-io#34403)

issue: milvus-io#30040

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. labels Jul 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.41%. Comparing base (60aab15) to head (ef2fe42).
Report is 149 commits behind head on 2.4.

Files Patch % Lines
pkg/common/common.go 78.94% 2 Missing and 2 partials ⚠️
internal/querycoordv2/meta/coordinator_broker.go 91.66% 1 Missing and 1 partial ⚠️
internal/querycoordv2/services.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34561      +/-   ##
==========================================
- Coverage   84.41%   84.41%   -0.01%     
==========================================
  Files         786      786              
  Lines      112475   112519      +44     
==========================================
+ Hits        94951    94982      +31     
- Misses      13305    13323      +18     
+ Partials     4219     4214       -5     
Files Coverage Δ
tests/integration/util_collection.go 100.00% <100.00%> (ø)
internal/querycoordv2/meta/coordinator_broker.go 91.28% <91.66%> (+1.73%) ⬆️
internal/querycoordv2/services.go 86.23% <66.66%> (-0.70%) ⬇️
pkg/common/common.go 79.41% <78.94%> (-0.19%) ⬇️

... and 34 files with indirect coverage changes

@yanliang567 yanliang567 added this to the 2.4.7 milestone Aug 6, 2024
@mergify mergify bot removed the ci-passed label Aug 6, 2024
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Aug 6, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2ac1bf7 into milvus-io:2.4 Aug 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants