Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove datanode reporting TT based on MQ implementation #34421

Merged

Conversation

jaime0815
Copy link
Contributor

issue: #34420

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jul 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 4, 2024
@jaime0815 jaime0815 force-pushed the remove-dd-report-tt-with-mq branch from 139fb29 to 7d55abb Compare July 5, 2024 02:02
Signed-off-by: jaime <yun.zhang@zilliz.com>
@jaime0815 jaime0815 force-pushed the remove-dd-report-tt-with-mq branch from 7d55abb to 7be1a38 Compare July 5, 2024 02:48
@mergify mergify bot added the ci-passed label Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (7611128) to head (7be1a38).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34421      +/-   ##
==========================================
- Coverage   80.92%   80.63%   -0.29%     
==========================================
  Files        1113     1112       -1     
  Lines      138345   138301      -44     
==========================================
- Hits       111960   111524     -436     
- Misses      22145    22538     +393     
+ Partials     4240     4239       -1     
Files Coverage Δ
internal/datacoord/channel_store.go 80.74% <ø> (ø)
internal/datacoord/server.go 72.75% <ø> (+0.98%) ⬆️
internal/datacoord/services.go 84.31% <ø> (+0.21%) ⬆️
...ternal/datanode/compaction/clustering_compactor.go 61.86% <ø> (ø)
internal/datanode/data_node.go 75.38% <100.00%> (-0.13%) ⬇️
internal/datanode/pipeline/data_sync_service.go 79.05% <100.00%> (+4.05%) ⬆️
...nternal/datanode/pipeline/flow_graph_write_node.go 85.07% <ø> (+0.45%) ⬆️
internal/datanode/util/timetick_sender.go 100.00% <ø> (ø)
internal/proxy/search_util.go 84.61% <ø> (ø)
pkg/util/paramtable/component_param.go 98.48% <ø> (-0.01%) ⬇️
... and 1 more

... and 37 files with indirect coverage changes

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jaime0815, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 21fc5f5 into milvus-io:master Jul 5, 2024
12 checks passed
@jaime0815 jaime0815 deleted the remove-dd-report-tt-with-mq branch July 8, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants