-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add lint rule to forbid gogo protobuf #34594
enhance: Add lint rule to forbid gogo protobuf #34594
Conversation
github.com/gogo/protobuf is deprecated and could be error prune after upgrade protobuf message to v2. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34594 +/- ##
==========================================
- Coverage 84.40% 84.39% -0.01%
==========================================
Files 876 876
Lines 115806 115806
==========================================
- Hits 97745 97738 -7
- Misses 13757 13760 +3
- Partials 4304 4308 +4
|
/lgtm |
github.com/gogo/protobuf is deprecated and could be error prune after upgrade protobuf message to v2. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
github.com/gogo/protobuf is deprecated and could be error prune after upgrade protobuf message to v2.