enhance: [2.4] Add lint rule to forbid gogo protobuf (#34594) #34630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/gogo/protobuf is deprecated and could be error prune after upgrade protobuf message to v2. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
@congqixia Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
mergify
bot
added
kind/enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #34630 +/- ##
=======================================
Coverage 84.42% 84.43%
=======================================
Files 786 786
Lines 112476 112538 +62
=======================================
+ Hits 94959 95022 +63
+ Misses 13308 13306 -2
- Partials 4209 4210 +1
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from master
pr: #34594
github.com/gogo/protobuf is deprecated and could be error prune after upgrade protobuf message to v2.