Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] Remove flushed segment in segment manager generated through import #34651

Merged

Conversation

xiaocai2333
Copy link
Contributor

issue: #34648

master pr: #34649

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 12, 2024
@xiaocai2333 xiaocai2333 modified the milestones: 2.3.19, 2.4.6 Jul 12, 2024
Copy link
Contributor

mergify bot commented Jul 12, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@mergify mergify bot added the ci-passed label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (4e02e57) to head (fcebd5c).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #34651       +/-   ##
===========================================
+ Coverage   69.74%   84.40%   +14.66%     
===========================================
  Files        1045      786      -259     
  Lines      136250   112551    -23699     
===========================================
- Hits        95021    94994       -27     
+ Misses      37018    13338    -23680     
- Partials     4211     4219        +8     
Files Coverage Δ
internal/datacoord/segment_manager.go 86.52% <50.00%> (-0.88%) ⬇️

... and 285 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

xiaofan-luan pushed a commit that referenced this pull request Jul 12, 2024
…d through import (#34652)

issue: #34648 

master pr: #34649 
2.4 pr: #34651

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot merged commit e1686d0 into milvus-io:2.4 Jul 12, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants