Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] Remove flushed segment in segment manager generated through import #34652

Conversation

xiaocai2333
Copy link
Contributor

issue: #34648

master pr: #34649
2.4 pr: #34651

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 12, 2024
@xiaocai2333 xiaocai2333 added this to the 2.4.6 milestone Jul 12, 2024
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007 czs007 modified the milestones: 2.4.6, 2.4.5-hotfix Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.96%. Comparing base (7f47f0d) to head (a5c3ee1).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           hotfix-2.4.5   #34652      +/-   ##
================================================
+ Coverage         81.94%   81.96%   +0.01%     
================================================
  Files              1015     1015              
  Lines            129462   129475      +13     
================================================
+ Hits             106094   106120      +26     
+ Misses            19363    19353      -10     
+ Partials           4005     4002       -3     
Files Coverage Δ
internal/datacoord/segment_manager.go 85.75% <50.00%> (-1.65%) ⬇️

... and 21 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@xiaofan-luan xiaofan-luan merged commit bd974f3 into milvus-io:hotfix-2.4.5 Jul 12, 2024
9 of 12 checks passed
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants