Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [hotfix-2.4.5]cherry pick some fixes #34659

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

weiliu1031
Copy link
Contributor

include pr: #34019,#34502,#34559

include pr: milvus-io#34019,milvus-io#34502,milvus-io#34559

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 12, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weiliu1031 weiliu1031 changed the title enhance: cherry pick some fixes enhance: [hotfix-2.4.5]cherry pick some fixes Jul 12, 2024
@czs007 czs007 added this to the 2.4.5-hotfix milestone Jul 12, 2024
@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.96%. Comparing base (7f47f0d) to head (9a29ed1).
Report is 2 commits behind head on hotfix-2.4.5.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           hotfix-2.4.5   #34659      +/-   ##
================================================
+ Coverage         81.94%   81.96%   +0.01%     
================================================
  Files              1015     1015              
  Lines            129462   129458       -4     
================================================
+ Hits             106094   106114      +20     
+ Misses            19363    19348      -15     
+ Partials           4005     3996       -9     
Files Coverage Δ
internal/querynodev2/delegator/delegator_data.go 88.76% <ø> (+0.74%) ⬆️
internal/indexnode/indexnode.go 82.08% <0.00%> (-0.48%) ⬇️
internal/querycoordv2/services.go 86.81% <0.00%> (+0.24%) ⬆️

... and 21 files with indirect coverage changes

@czs007 czs007 merged commit 59ef111 into milvus-io:hotfix-2.4.5 Jul 13, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants