Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix GetReplicas API return nil status (#33715) #34019

Merged

Conversation

weiliu1031
Copy link
Contributor

issue: #33702
pr: #33715

issue: milvus-io#33702

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 20, 2024
@sre-ci-robot sre-ci-robot requested review from sunby and yah01 June 20, 2024 06:47
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.27%. Comparing base (a7ae45c) to head (7dc959a).
Report is 6 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34019      +/-   ##
==========================================
+ Coverage   82.25%   82.27%   +0.01%     
==========================================
  Files        1015     1015              
  Lines      129458   129458              
==========================================
+ Hits       106483   106506      +23     
+ Misses      18974    18947      -27     
- Partials     4001     4005       +4     
Files Coverage Δ
internal/querycoordv2/services.go 86.81% <0.00%> (+0.24%) ⬆️

... and 37 files with indirect coverage changes

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 21, 2024
@chyezh
Copy link
Contributor

chyezh commented Jun 21, 2024

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7d1d5a8 into milvus-io:2.4 Jun 21, 2024
14 of 15 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Jul 12, 2024
include pr: milvus-io#34019,milvus-io#34502,milvus-io#34559

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
czs007 pushed a commit that referenced this pull request Jul 13, 2024
include pr: #34019,#34502,#34559

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants