Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add metrics for restful apis #35083

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

PowderLi
Copy link
Contributor

issue: #34968
pr: #34969

Signed-off-by: PowderLi <min.li@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 29, 2024
Copy link
Contributor

mergify bot commented Jul 29, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (cc188fb) to head (75cb6b9).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35083      +/-   ##
==========================================
- Coverage   81.10%   81.07%   -0.04%     
==========================================
  Files        1051     1051              
  Lines      136692   136714      +22     
==========================================
- Hits       110870   110842      -28     
- Misses      21620    21654      +34     
- Partials     4202     4218      +16     
Files Coverage Δ
pkg/metrics/metrics.go 100.00% <ø> (ø)
pkg/metrics/proxy_metrics.go 100.00% <100.00%> (ø)
internal/distributed/proxy/service.go 83.97% <78.94%> (-0.17%) ⬇️

... and 24 files with indirect coverage changes

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 30, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jul 30, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fa9d606 into milvus-io:2.4 Jul 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants