Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [skip e2e] effective way to use cache (#34774) #35109

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

yellow-shine
Copy link
Collaborator

@yellow-shine yellow-shine commented Jul 30, 2024

See also #34483

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 30, 2024
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jul 30, 2024
Copy link
Contributor

mergify bot commented Jul 30, 2024

@yellow-shine Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@congqixia
Copy link
Contributor

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement Issues or changes related to enhancement label Jul 30, 2024
@mergify mergify bot added the ci-passed label Jul 30, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yellow-shine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 273e920 into milvus-io:master Jul 30, 2024
6 checks passed
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Aug 2, 2024
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Aug 2, 2024
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Aug 2, 2024
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Aug 2, 2024
sre-ci-robot pushed a commit that referenced this pull request Aug 6, 2024
issue: #34876
#35109

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Aug 6, 2024
issue: #34876
#35109

---------

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
…-io#35109)

See also milvus-io#34483

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/feature Issues related to feature request from users lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants