Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Lint check fails due to lack of static-check #34483

Closed
1 task done
congqixia opened this issue Jul 8, 2024 · 0 comments
Closed
1 task done

[Bug]: Lint check fails due to lack of static-check #34483

congqixia opened this issue Jul 8, 2024 · 0 comments
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 467113d
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Lint check fails due to lack of static-check

Expected Behavior

Lint check shall passes stably

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jul 8, 2024
@congqixia congqixia self-assigned this Jul 8, 2024
@congqixia congqixia mentioned this issue Jul 8, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 9, 2024
@congqixia
enhance: Fix lint issues from recent PRs (#34482)
3333160 
See also #34483
Some lint issues are introduced due to lack of static check run. This PR
fixes these problems.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 29, 2024
@congqixia
enhance: Enable linux code checker
dba9d40 
See also milvus-io#34483

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 29, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jul 30, 2024
@congqixia
enhance: Enable linux code checker
f7e254c 
See also milvus-io#34483

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jul 30, 2024
@congqixia
enhance: Enable linux code checker (#35084)
de8a266 
See also #34483

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 30, 2024
@congqixia
enhance: Fix go&cpp lint issues
244a0f9 
See also milvus-io#34483

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 30, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jul 30, 2024
@congqixia
enhance: Fix go&cpp lint issues
9f280ec 
See also milvus-io#34483

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 30, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 30, 2024
@yellow-shine
feat: [skip e2e] effective way to use cache (#34774) (#35109)
273e920 
See also #34483

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jul 30, 2024
@congqixia
enhance: [2.4] Fix go&cpp lint issues (#35107)
8991dc2 
See also #34483

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Aug 1, 2024
@congqixia
enhance: Resolve ChunkFileWriter lint issue
a6a3f2b 
See also milvus-io#34483

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Aug 1, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Aug 1, 2024
@congqixia
enhance: Resolve ChunkFileWriter lint issue (#35166)
a642a26 
See also #34483

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
yellow-shine added a commit to yellow-shine/milvus that referenced this issue Aug 2, 2024
@yellow-shine
feat: [skip e2e] effective way to use cache (milvus-io#34774) (milvus…
2f636af 
…-io#35109)

See also milvus-io#34483

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
yellow-shine added a commit to yellow-shine/milvus that referenced this issue Aug 2, 2024
@yellow-shine
feat: [skip e2e] effective way to use cache (milvus-io#34774) (milvus…
baaa1f1 
…-io#35109)

See also milvus-io#34483

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
yellow-shine added a commit to yellow-shine/milvus that referenced this issue Aug 2, 2024
@yellow-shine
feat: [skip e2e] effective way to use cache (milvus-io#34774) (milvus…
c30d883 
…-io#35109)

See also milvus-io#34483

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
yellow-shine added a commit to yellow-shine/milvus that referenced this issue Aug 2, 2024
@yellow-shine
feat: [skip e2e] effective way to use cache (milvus-io#34774) (milvus…
3783e16 
…-io#35109)

See also milvus-io#34483

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
@congqixia @sumitd2
enhance: Enable linux code checker (milvus-io#35084)
c2e3e29 
See also milvus-io#34483

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
@yellow-shine @sumitd2
feat: [skip e2e] effective way to use cache (milvus-io#34774) (milvus…
330868b 
…-io#35109)

See also milvus-io#34483

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
@congqixia @sumitd2
enhance: Resolve ChunkFileWriter lint issue (milvus-io#35166)
5ef80b2 
See also milvus-io#34483

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia