NSG support MetricType IP #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youny626
approved these changes
Nov 26, 2019
cydrain
reviewed
Nov 26, 2019
| } | ||
|
|
||
| float | ||
| DistanceIP::Compare(const float* a, const float* b, unsigned size) const { |
There was a problem hiding this comment.
why unsigned ?
can use int32_t or int64_t ?
cydrain
reviewed
Nov 26, 2019
| namespace knowhere { | ||
| namespace algo { | ||
|
|
||
| struct Distance { |
cydrain
approved these changes
Nov 26, 2019
Codecov Report
@@ Coverage Diff @@
## 0.6.0 #554 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 282 282
Lines 12131 12131
=======================================
Hits 10701 10701
Misses 1430 1430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533