Expose metrics of QueryCoord and QueryNodes #7113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-ci-robot
requested review from
bigsheeper,
czs007,
fishpenguin,
jeffoverflow,
wxyucs,
xiaocai2333 and
XuanYang-cn
|
PTAL |
xige-16
reviewed
Aug 16, 2021
xige-16
reviewed
Aug 16, 2021
xige-16
reviewed
Aug 16, 2021
longjiquan
force-pushed
the
mep-8-metrics
branch
3 times, most recently
from
dc0b2f8
to
5da860b
Compare
|
/lgtm |
longjiquan
force-pushed
the
mep-8-metrics
branch
from
5da860b
to
578dc81
Compare
Codecov Report
@@ Coverage Diff @@
## master #7113 +/- ##
==========================================
- Coverage 42.97% 42.92% -0.05%
==========================================
Files 214 218 +4
Lines 25520 25556 +36
==========================================
+ Hits 10968 10971 +3
- Misses 13224 13253 +29
- Partials 1328 1332 +4
Continue to review full report at Codecov.
|
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
longjiquan
force-pushed
the
mep-8-metrics
branch
from
578dc81
to
2566c4c
Compare
|
/lgtm |
czs007
reviewed
Aug 17, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, DragonDriver The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dragondriver jiquan.long@zilliz.com
issue: #7091