-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description event extras #8264
Add description event extras #8264
Conversation
52a4fa0
to
fa450e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #8264 +/- ##
==========================================
+ Coverage 77.88% 77.90% +0.02%
==========================================
Files 251 251
Lines 32639 32647 +8
==========================================
+ Hits 25422 25435 +13
+ Misses 5127 5110 -17
- Partials 2090 2102 +12
|
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
fa450e6
to
ece08d4
Compare
/cc @xiaofan-luan |
/lgtm |
@xiaofan-luan: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
please check code coverage and modify the documents about binlog |
There are many codes associated with binary.Write() and it is difficult to inject errors. This code coverage has reached the top. |
/lgtm |
@xiaofan-luan: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@xiaofan-luan: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: godchen0212, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the sre robot hit some issues, mark lgtm and approve directly |
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
Add description event extras.
Issue #8263
Signed-off-by: godchen qingxiang.chen@zilliz.com