Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description event extras #8264

Merged

Conversation

godchen0212
Copy link
Contributor

Add description event extras.
Issue #8263

Signed-off-by: godchen qingxiang.chen@zilliz.com

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #8264 (ece08d4) into master (0c35cd5) will increase coverage by 0.02%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8264      +/-   ##
==========================================
+ Coverage   77.88%   77.90%   +0.02%     
==========================================
  Files         251      251              
  Lines       32639    32647       +8     
==========================================
+ Hits        25422    25435      +13     
+ Misses       5127     5110      -17     
- Partials     2090     2102      +12     
Impacted Files Coverage Δ
internal/storage/binlog_writer.go 86.77% <ø> (ø)
internal/storage/event_header.go 100.00% <ø> (ø)
internal/storage/print_binlog.go 63.36% <ø> (-0.93%) ⬇️
internal/storage/event_data.go 89.67% <40.00%> (-7.45%) ⬇️
internal/storage/event_writer.go 80.23% <60.00%> (-0.95%) ⬇️
internal/storage/unsafe.go 100.00% <100.00%> (ø)
internal/proxy/timestamp.go 78.57% <0.00%> (-14.29%) ⬇️
internal/distributed/rootcoord/client/client.go 58.92% <0.00%> (-5.06%) ⬇️
internal/proxy/channels_time_ticker.go 78.21% <0.00%> (-4.96%) ⬇️
internal/indexnode/indexnode_mock.go 87.82% <0.00%> (-1.29%) ⬇️
... and 11 more

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
@godchen0212 godchen0212 added the kind/enhancement Issues or changes related to enhancement label Sep 22, 2021
@godchen0212
Copy link
Contributor Author

/cc @xiaofan-luan
/cc @czs007
/assign @xiaofan-luan

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

@xiaofan-luan: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiaofan-luan
Copy link
Contributor

please check code coverage and modify the documents about binlog

@godchen0212
Copy link
Contributor Author

There are many codes associated with binary.Write() and it is difficult to inject errors. This code coverage has reached the top.

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

@xiaofan-luan: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

@xiaofan-luan: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: godchen0212, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan
Copy link
Contributor

the sre robot hit some issues, mark lgtm and approve directly

@sre-ci-robot sre-ci-robot merged commit 10c07a3 into milvus-io:master Sep 23, 2021
xiyichan pushed a commit to xiyichan/milvus that referenced this pull request Sep 26, 2021
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
xiyichan pushed a commit to xiyichan/milvus that referenced this pull request Sep 26, 2021
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants