Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LoadPartial interface for DataKV #9554

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

longjiquan
Copy link
Contributor

Signed-off-by: dragondriver jiquan.long@zilliz.com
/kind enhancement
/cc @czs007
issue: #9535

@sre-ci-robot sre-ci-robot added kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines. labels Oct 9, 2021
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Oct 9, 2021
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #9554 (be8491c) into master (d0bc0cd) will increase coverage by 0.06%.
The diff coverage is 70.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9554      +/-   ##
==========================================
+ Coverage   80.05%   80.12%   +0.06%     
==========================================
  Files         248      248              
  Lines       45627    45658      +31     
==========================================
+ Hits        36528    36582      +54     
+ Misses       7030     7012      -18     
+ Partials     2069     2064       -5     
Impacted Files Coverage Δ
internal/kv/minio/minio_kv.go 78.97% <70.00%> (-1.16%) ⬇️
internal/kv/mem/mem_kv.go 53.52% <72.72%> (+1.61%) ⬆️
internal/datacoord/segment_manager.go 84.39% <0.00%> (-1.07%) ⬇️
internal/datacoord/cluster.go 81.40% <0.00%> (-0.73%) ⬇️
internal/proxy/impl.go 81.35% <0.00%> (-0.24%) ⬇️
internal/rootcoord/meta_table.go 81.02% <0.00%> (+0.20%) ⬆️
...ternal/util/rocksmq/server/rocksmq/rocksmq_impl.go 76.63% <0.00%> (+0.67%) ⬆️
internal/distributed/rootcoord/client/client.go 92.25% <0.00%> (+0.70%) ⬆️
internal/querycoord/querynode.go 65.30% <0.00%> (+0.81%) ⬆️
internal/rootcoord/task.go 82.23% <0.00%> (+0.85%) ⬆️
... and 5 more

@czs007
Copy link
Contributor

czs007 commented Oct 9, 2021

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, DragonDriver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 41bd866 into milvus-io:master Oct 9, 2021
@longjiquan longjiquan deleted the 9535-datakv-load-partial branch December 21, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants