Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not warn about very old fork #25

Closed
quentinlesceller opened this issue Oct 22, 2018 · 2 comments
Closed

Do not warn about very old fork #25

quentinlesceller opened this issue Oct 22, 2018 · 2 comments

Comments

@quentinlesceller
Copy link
Member

Currently grin-explorer warn about forks sometimes older than 1000. I would say warning about less than 60 blocks seems okay but not more than that.
@quentinlesceller quentinlesceller changed the title Do not display very old fork Do not warn about very old fork Oct 22, 2018
@hendi
Copy link
Member

hendi commented Nov 2, 2018

Yup, agreed, please feel free to go ahead and change that (I'm on holiday currently). 1000 is definitely too long, 60 sounds good!

I've got some local work for a much better fork/chain detection, hope to finish that up and push it soon.

@hendi
Copy link
Member

hendi commented Jan 7, 2019

Fixed with acfc8d3

@hendi hendi closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hendi @quentinlesceller