Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter question #5

Closed
owendall opened this issue Apr 4, 2016 · 2 comments
Closed

Parameter question #5

owendall opened this issue Apr 4, 2016 · 2 comments

Comments

@owendall
Copy link

owendall commented Apr 4, 2016

var correlationCutoff = 0.25;

Should the parameter "cutoff" in the function getCorrelationGraph actually be "correlationCuttoff"?

"function var getCorrelationGraph = function(correlationMatrix, cutoff)"

@mimno
Copy link
Owner

mimno commented Apr 14, 2016

In this case cutoff is a local variable for the function, so I do want to make it clear that it's a different variable. But correlationCutoff is also not being used, which isn't great. At some point I switched from correlation to pointwise mutual information, which has a different scale. The default cutoff is -100.0, which is hard-coded when the function is actually executed.

@mimno mimno closed this as completed Apr 14, 2016
@owendall
Copy link
Author

owendall commented Apr 17, 2016

Ahh, Gotcha. Somehow I missed that line while going through the code...
var correlationGraph = getCorrelationGraph(correlationMatrix, -100.0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants