Fixed bug where the whenever_name was not getting set properly, causing multiple crontab entries. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alled (set_default) causing multiple crontab entries
ipd
changed the title
gabskoro
added a commit
that referenced
this pull request
Sep 6, 2015
Fixed bug where the whenever_name was not getting set properly, causing multiple crontab entries.
|
Tnx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem where mina deployments were creating multiple crontab entries.
This was caused because our project's schedule.rb file sets the :domain key after requiring 'mina/whenever'. The code as written was using set_default to set the :whenever_name key at require time.
I refactored the code to use a lambda which uses the :whenever_name key if defined, otherwise it sets the name to the default name. This fixes the bug because it is evaluated at runtime, so our :domain key is picked up as defined. It will also still work with if there is a user-defined :whenever_name variable.