Refactor pretty printer #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovro-bikic
commented
Aug 13, 2021
| spec.add_development_dependency 'rspec', '~> 3.5.0' | ||
| spec.add_development_dependency 'pry-byebug' | ||
| spec.add_development_dependency 'pry' |
There was a problem hiding this comment.
Had to replace this because it's not supported on jruby (I think it's also a better option).
Closed
d4be4st
approved these changes
Aug 14, 2021
lovro-bikic
commented
Aug 14, 2021
|
|
||
| describe '#run', :suppressed_output do | ||
| it 'executes the script' do | ||
| expect { runner.run }.to output('').to_stdout |
There was a problem hiding this comment.
@d4be4st this spec actually executes the command (in this case true, which outputs nothing). So that at least covers calling Open3.popen3 and waiting for the process to end.
The part that is not tested (and I'm not sure how to test it) is handling SIGINT and output formatting.
Merged
|
Fixes #534. |
This was referenced Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces open4 with open3 to remove dependency on an external gem. With this fix the error
NotImplementedError: fork is not available on this platformis fixed on jruby, so we can support that version of Ruby too (I tested this also by building the gem and trying it out on a project with jruby, it works.).