E2E specs #698
Merged
E2E specs #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovro-bikic
commented
Aug 20, 2021
| @@ -25,3 +25,6 @@ jobs: | |||
| bundler-cache: true | |||
| - run: bundle exec rubocop | |||
| - run: bundle exec rspec | |||
| - name: E2E tests | |||
| if: ${{ success() && matrix.os != 'macos-10.15' }} | |||
There was a problem hiding this comment.
We can't run E2E tests on Mac because it doesn't come with docker, see actions/runner-images#17.
| @@ -14,9 +14,9 @@ def name | |||
| end | |||
|
|
|||
| # :nocov: | |||
| def run | |||
| def run(*args) | |||
There was a problem hiding this comment.
This is how run method is defined in Rake::Application.
| @@ -8,14 +8,14 @@ class Pretty | |||
| attr_reader :script | |||
|
|
|||
| def initialize(script) | |||
| @script = script | |||
| @script = Shellwords.shellsplit(script) | |||
There was a problem hiding this comment.
This was a bug I introduced in #686, E2E tests caught it.
| @@ -0,0 +1,27 @@ | |||
| -----BEGIN OPENSSH PRIVATE KEY----- | |||
There was a problem hiding this comment.
Usually this isn't safe to keep in repos, but I generated this key just for e2e purposes.
d4be4st
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds E2E tests. The idea is to create a docker container into which we can SSH and execute mina commands on it. I added three specs which are ran in this order:
mina deploybefore callingmina setupfirst (it fails)mina setup(it passes)mina deploy(it passes since setup has been run)I'll add more tests later, this was just initially added to make it work.