DSL tests #695
Merged
DSL tests #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for DSL.
This PR is a bit bigger because in order to achieve testing custom tasks for DSL, I wanted to isolate all specs so that they don't affect each other. Before, if one spec changed the configuration or added a new rake task, these changes would be visible in other specs. With the changes in this PR, each spec should now hopefully be isolated, and one spec's changes shouldn't affect other specs.
This PR also added Gemfile.lock to version control. The reasoning is outlined here, but the specific issue which prompted me into doing this is GA failing because it installed different versions of gems than those which I had locally (you can see the failing test run here).