Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximum nesting error in minibuffer-hook after using consult-theme #13

Closed
Luis-Henriquez-Perez opened this issue Nov 30, 2020 · 9 comments
Labels
bug Something isn't working

Comments

@Luis-Henriquez-Perez
Copy link

After using consult-theme, I couldn't keep using selectrum because of an error in selectrum--minibuffer-post-command-hook saying that maximum lisp nesting exceeded.

@hpdeifel
Copy link

I also observed this first after calling consult-theme, but now it happened again without me changing the theme beforehand.

This is on commit 50c27fee9fc9a7ccff5f08ca10f4c66d8276657d with consult-annotate-mode active

@hpdeifel
Copy link

Disabling consult-annotate-mode seems to fix it

@minad
Copy link
Owner

minad commented Nov 30, 2020

I am not seeing this. Could you please describe your setup or at least tell me your Emacs version? A backtrace would also help.

@minad minad added the bug Something isn't working label Nov 30, 2020
@hpdeifel
Copy link

  • Emacs: 27.1
  • selectrum: 9b44a6ae91aa2efabaa768d0a2192e23d3d7f930
  • consult: 50c27fe

This took some time to reproduce from scratch, but I managed to do it:

  1. emacs -Q
  2. Load the following config:
(use-package selectrum
  :straight t
  :init
  (selectrum-mode +1))

(use-package consult
  :straight (consult :type git :host github :repo "minad/consult"))
  1. M-x consult-annotate-mode RET
  2. M-x consult-theme RET RET
  3. M-x

The last M-x is where the error happens. It seems that consult-annotate-mode has to be enabled interactively, not from the config file. Maybe it's important to run selectrum once before enabling it.

@minad
Copy link
Owner

minad commented Nov 30, 2020

Ah ok, maybe the issue is that consult-annotate-mode has to be run AFTER enabling selectrum-mode. This is not yet documented and I probably should sort this out.

@minad
Copy link
Owner

minad commented Nov 30, 2020

@hpdeifel I reproduced the bug now. Thank you.

@minad minad closed this as completed in 97dc871 Nov 30, 2020
@minad
Copy link
Owner

minad commented Nov 30, 2020

@hpdeifel @Luis-Henriquez-Perez Please let me know if it works for you!

@hpdeifel
Copy link

hpdeifel commented Dec 1, 2020

Seems to work well now, thank you!

@minad
Copy link
Owner

minad commented Dec 1, 2020

Thank you for reporting back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants