Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digit arguments for vertico-next and vertico-previous #54

Closed
karthink opened this issue Jun 5, 2021 · 3 comments
Closed

digit arguments for vertico-next and vertico-previous #54

karthink opened this issue Jun 5, 2021 · 3 comments

Comments

@karthink
Copy link

karthink commented Jun 5, 2021

Can vertico-next and vertico-previous be made to take digit arguments? (Similar to next-line and previous-line.)

I often find myself pressing something like C-4 C-n in the minibuffer. I looked at the code but the check for vertico-cycle makes it a little trickier to trivially modify.

I've been trying out Vertico in light of our conversation in a recent Embark issue thread after a year long stint with Embark live-collect buffers. Vertico feels blazing fast in comparison! But naturally, I find myself missing the full buffer editing features, like jumping to candidates with isearch/avy or digit arguments on movement commands.

@minad
Copy link
Owner

minad commented Jun 5, 2021

Vertico feels blazing fast in comparison!

That's what it is made for 😄

But naturally, I find myself missing the full buffer editing features, like jumping to candidates with isearch/avy or digit arguments on movement commands.

I think such features are less useful in the minibuffer, since the minibuffer only shows a tiny excerpt of all the candidates (@oantolin likes to tell that minibuffer completion is like looking at the candidates through a pinhole ;). Of course you can always embar-collect-snapshot to get a full buffer to search inside. The idea of minibuffer completion from my perspective is to avoid the context switch to isearch, you are already entering a search string - so why suddenly switch the search modus to isearch?

Supporting prefix arguments can certainly be considered, in particular since it aligns the movement with regular buffer movement.

  • vertico-next/previous -> jump by n lines
  • vertico-insert -> insert nth candidate
  • vertico-exit -> insert nth candidate
  • vertico-save -> save nth candidate

@minad
Copy link
Owner

minad commented Jun 5, 2021

Note that there is also vertico-scroll-up/down.

@minad
Copy link
Owner

minad commented Jun 10, 2021

Implemented in 8d12bc2

@minad minad closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants