Support for Python 3.11

[mindflayer]

• Migrating the HTTP[S] mock from relying on http-parser to httptools.
• Never discovered the root cause for the failing tests with aiohttp/Python 3.11 (first time ever I added @pytest.mark.xfail to a test). Same test works with httpx, so I suspect it's related to a client issue. I'll probably migrate to httpx as the one for testing async/await code.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[amotl]

Hi there,

aiming to add support for Python 3.11 to the Terkin Datalogger, we had to downgrade to mocket<3.9 (see hiveeyes/terkin-datalogger@3b8a94bb0), in order to make it work on Python 3.11.

It looks like http-parser is not ready for Python 3.11 yet, see benoitc/http-parser#95.

With kind regards,
Andreas.

[mindflayer]

Hi Andreas, I'm aware of it and keeping an eye on their repo. There is already an issue with the fix but it hasn't been merged yet. I was planning to write to the author in case it won't be taken care of soon. Regards, Giorgio

…

On Sat, 26 Nov 2022, 18:26 Andreas Motl, ***@***.***> wrote: Hi there, aiming to add support for Python 3.11 to the Terkin Datalogger <https://github.com/hiveeyes/terkin-datalogger>, we had to downgrade to mocket<3.9 (see ***@***.*** <hiveeyes/terkin-datalogger@3b8a94bb0>), in order to make it work on Python 3.11. It looks like http-parser is not ready for Python 3.11 yet. With kind regards, Andreas. — Reply to this email directly, view it on GitHub <#181 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEAXXILSDXTEFOPVER5FRTWKJI4RANCNFSM5WSLLATQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[amotl]

Thank you! I've added a comment to benoitc/http-parser#95, and exercised the upgrade to Python 3.11 and mocket-3.9.x on behalf of hiveeyes/terkin-datalogger#116 ¹.

Footnotes

1. https://github.com/hiveeyes/terkin-datalogger/actions/runs/3555613712/jobs/5972413084 ↩

[amotl]

Hi again,

[...] we had to downgrade to mocket<3.9 (see hiveeyes/terkin-datalogger@3b8a94bb0), in order to make it work on Python 3.11.

With hiveeyes/terkin-datalogger@ffcffbaa26, the test suite now uses a modern version of Mocket for all Python versions <3.11, while still resorting to mocket<3.9 on Python 3.11.

We know it is not an optimal solution, and this release probably lacks many features, but it was enough to satisfy our test suite, and it might help others as well.

With kind regards,
Andreas.

[mindflayer]

Hi @amotl, I replaced http-parser with the modern httptools, but some tests are failing on Python 3.11 - nothing to do with the parser, though.
I'll do my best to try to tackle those issues and close this PR as soon as possible. Feel free to have a look at them, in case you have some time for it.

[amotl]

Hi @mindflayer,

thanks for sharing those news. I had a look at the exception message aiohttp.client_exceptions.ClientOSError: Cannot write to closing transport, but the code at this place is not trivial, so I could not figure it out.

Maybe those discussions have some hints about that exception?

• Cannot write to closing transport aio-libs/aiohttp#4587
• #4587 Always check transport is not closing before reuse aio-libs/aiohttp#4778

With kind regards,
Andreas.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
3.6% Duplication