Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

ImportError: cannot import name 'basestring' from 'pyparsing' #41

Open
YarShev opened this issue Oct 28, 2021 · 8 comments
Open

ImportError: cannot import name 'basestring' from 'pyparsing' #41

YarShev opened this issue Oct 28, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@YarShev
Copy link

YarShev commented Oct 28, 2021

Hi guys, I noticed that dfsql doesn't work with new versions of pyparsing (since 3.0.0). This should probably be fixed.

@YarShev
Copy link
Author

YarShev commented Oct 28, 2021

import dfsql.utils

./miniconda3/lib/site-packages/dfsql/utils.py in <module>

----> 1 from pyparsing import basestring
      2
      3 from dfsql.engine import pd
      4 from dfsql.exceptions import QueryExecutionException
      5

ImportError: cannot import name 'basestring' from 'pyparsing' (./miniconda3/lib/site-packages/pyparsing/__init__.py)

@btseytlin
Copy link
Contributor

Thanks.

This is fixed in #39, but the mysterious Ray/Dask issues are preventing me from releasing the fix. You can checkout basestring_fix if you want to test dfsql without this problem

@YarShev
Copy link
Author

YarShev commented Oct 28, 2021

Yes, I do not see the issue related to the import error in basestring_fix branch but it would be great to have a new release of dfsql to support it in Modin as we normally do.

@btseytlin
Copy link
Contributor

Yes, I do not see the issue related to the import error in basestring_fix branch but it would be great to have a new release of dfsql to support it in Modin as we normally do.

Absolutely! But currently dfsql doesn't pass tests on OSX with Dask engine and on Ubuntu with Ray engine. Can't make a release until this is resolved

@YarShev
Copy link
Author

YarShev commented Oct 29, 2021

Hope this will happen soon.

@YarShev
Copy link
Author

YarShev commented Mar 28, 2022

@btseytlin, what is the status on this issue?

@btseytlin
Copy link
Contributor

@btseytlin, what is the status on this issue?

CC @StpMax

@tomhuds tomhuds added the bug Something isn't working label May 25, 2023
@tomhuds
Copy link

tomhuds commented May 25, 2023

@StpMax can we close?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants