Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added action step after 'deploy to pypi' to try to install latest min… #869

Closed
wants to merge 2 commits into from
Closed

Conversation

jumc
Copy link

@jumc jumc commented Oct 24, 2020

…dsdb

Fixes #804

Added a step to run in command line "pip install mindsdb" after deploying to pypi

mindsdb

@mindsdbadmin
Copy link
Contributor

mindsdbadmin commented Oct 26, 2020

CLA Assistant Lite bot All contributors have signed the CLA ✍️

Copy link
Contributor

@George3d6 George3d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably requires a sleep 10s before trying to pip install mindsdb because otherwise it might not be deployed yet, it takes a bit for pip to actualize it's repos.

@George3d6 George3d6 added hacktoberfest Contirubte to MindsDB and participate in Hacktoberfest. hacktoberfest-accepted labels Oct 26, 2020
@George3d6
Copy link
Contributor

@jumc are you still working on this ?

@jumc
Copy link
Author

jumc commented Oct 31, 2020

I have read the CLA Document and I hereby sign the CLA

mindsdbadmin added a commit that referenced this pull request Oct 31, 2020
@jumc
Copy link
Author

jumc commented Oct 31, 2020

@George3d6 I've added the sleep command and reran the checks on my fork (they passed). Is there a way to run them again here?

@George3d6
Copy link
Contributor

@jumc there's some other bugs causing tests to fail, once that's fixed I will merge

@ilia-tsyplenkov
Copy link
Contributor

Closed since it is outdated #939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Contirubte to MindsDB and participate in Hacktoberfest.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip install after deploy
4 participants