Install mindsdb from pypi in deploy step #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
George3d6
suggested changes
Nov 16, 2020
.github/workflows/mindsdb.yml
Outdated
Comment on lines
71
to
75
| - name: Install latest version from pypi (just testing) | ||
| run: | | ||
| sleep 20 | ||
| pip install mindsdb | ||
| pip show mindsdb |
There was a problem hiding this comment.
Was this for testing when you made the PR, if so please remove before merging. all else looks fine.
ilia-tsyplenkov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #804
Release image (which created in a
deploystep) needs to contain MindsDB version installed from PyPi repository (not from local source files) In this case we ensure that release image and PyPi have same version.