-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move lanchain skills to langchain handler. #8711
Conversation
@ea-rus @paxcema I've asked for your reviews as I don't understand the langchain skills and I don't know how to test my changes. They are deployed to https://alpha.dev.mindsdb.com now if you could take a look please :) |
Looping in @tmichaeldb as well. Code changes look good to me, though it's possible we may want to bring these back into For that, it'd be important to understand what is using |
@paxcema, skill_tool.py uses langchain handler. When we return it to skills controller it should be set of functions used by langchain handler (but not dependent on langchain) |
Description
This fixes an issue that has caused our base docker image to grow from ~500MB to 3GB.
A dependency. of the langchain skills was added that eventually requires torch. The goal is for our base image to not require torch and be a lot smaller as a result.
This PR moves the skills code into the langchain handler, which can then not be installed by default. The langchain handler is the only handler that uses this code at present.
Type of change
(Please delete options that are not relevant)