Use the class selected with the cursor for the Find Mixins action #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenWav
requested changes
Dec 3, 2016
| import com.intellij.psi.PsiMember | ||
| import com.intellij.psi.PsiModifier | ||
| import com.intellij.psi.PsiModifierListOwner | ||
| import com.intellij.psi.* |
| import com.intellij.psi.search.GlobalSearchScope | ||
| import org.jetbrains.annotations.Contract | ||
| import java.util.Collections | ||
| import java.util.* |
|
@DemonWav Fixed |
DenWav
approved these changes
Dec 4, 2016
kashike
approved these changes
Dec 4, 2016
|
I'm not comfortable with this implementation, as getClassOfElement()'s purpose is specifically to get the class that contains the element, never the class of the element. I think this should be implemented in FindMixinsAction instead. |
|
@DemonWav I've modified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming I have a Mixin class open in the editor:
When I right click the
Entity.classpart I'd expect theFind mixinsaction to search for other Mixins that targetEntityand not for Mixins which targetMixinEntity. With these changes it will attempt to resolve the selected reference before checking for mixins of the current class.Since the changed method is also used in other contexts I'm not entirely sure if the change also breaks something else.