Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#607 broke stuff #613

Closed
fluxionary opened this issue May 16, 2022 · 3 comments
Closed

#607 broke stuff #613

fluxionary opened this issue May 16, 2022 · 3 comments

Comments

@fluxionary
Copy link
Contributor

#607 broke stuff for servers which use basic_materials, which is many, because it's been around forever and many mods depend on it. #607 now adds a second kind of silicon, and breaks things that depend on that material from basic_materials. #607 also caused #611. Making the mod "independent from MTG" shouldn't have broken servers that use MTG, and yet it has. This is part of a broader effort to "remove dependencies", but by breaking functionality of servers currently running MTG (see e.g. mt-mods/homedecor_modpack#28 and some other changes by people in mt-mods to mods they've adopted).

See also #440

@TurkeyMcMac
Copy link
Contributor

I don't recall adding a second kind of silicon. I'm pretty sure Mesecons has had its own silicon for a while that basic_materials overrides. Crafting with silicon still works for me when basic_materials is enabled (using Minetest 5.4.1.)

#611 was caused by an engine bug.

@fluxionary
Copy link
Contributor Author

I may have just been caught in a bad mood when I created this, I'll look into the origin of the issue on my tomorrow.

@fluxionary
Copy link
Contributor Author

I think you are correct. I think basic_materials's alias stopped working because the dependency ordering changed and things now load in a different order, closing this, and apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants