Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make homedecor game agnostic #28

Merged
merged 51 commits into from May 3, 2022
Merged

make homedecor game agnostic #28

merged 51 commits into from May 3, 2022

Conversation

wsor4035
Copy link
Collaborator

@wsor4035 wsor4035 commented Apr 2, 2022 •
edited

may interest @BuckarooBanzay @sfence

  • building_blocks
  • fake_fire
  • homedecor_3d_extras
  • homedecor_bathroom
  • homedecor_bedroom
  • homedecor_books
  • homedecor_climate_control
  • homedecor_clocks
  • homedecor_cobweb
  • homedecor_common
  • heomdecor_doors_and_gates
  • homedecor_electricial
  • homedecor_electronics
  • homedecor_exterior
  • homedecor_fences
  • homedecor_foyer
  • homedecor_furniture
  • homedecor_furniture_medieval
  • homedecor_gastronomy
  • homedecor_inbox
  • homedecor_kitchen
  • homedecor_laundry
  • homedecor_lighting
  • homedecor_misc
  • homedecor_office
  • homedecor_pictures_and_paintings
  • homedecor_plasmascreen
  • homedecor_roofing
  • homedecor_seating
  • homedecor_tables
  • homedecor_trash_cans
  • homedecor_wardrobe
  • homedecor_windows_and_treatments
  • itemframes
  • lavalamp

@wsor4035 wsor4035 self-assigned this Apr 2, 2022
@wsor4035 wsor4035 added the enhancement New feature or request label Apr 2, 2022
This was linked to issues Apr 2, 2022
Kitchen Cabinet Recipes Broken #4
Open
make homedecor game agnostic #13
Closed
fix all warnings #15
Closed
@wsor4035 wsor4035 marked this pull request as draft April 2, 2022 20:41
@wsor4035 wsor4035 mentioned this pull request Apr 5, 2022
Closed
@wsor4035
Copy link
Collaborator Author

note to self, add metatable to homedecor.materials, so that unknown materials return ""

@wsor4035 wsor4035 marked this pull request as ready for review May 1, 2022 23:42
fluxionary
fluxionary approved these changes May 2, 2022
View reviewed changes
homedecor_doors_and_gates/init.lua Outdated Show resolved Hide resolved
homedecor_bathroom/init.lua Show resolved Hide resolved
fluxionary
fluxionary previously requested changes May 2, 2022
View reviewed changes
fake_fire/init.lua Show resolved Hide resolved
@BuckarooBanzay BuckarooBanzay mentioned this pull request May 3, 2022
Closed
@wsor4035 wsor4035 merged commit 546cd71 into master May 3, 2022
@fluxionary fluxionary mentioned this pull request May 16, 2022
Closed
@Niklp09 Niklp09 deleted the game_agnostic branch October 4, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluxionary fluxionary fluxionary left review comments

@S-S-X S-S-X S-S-X left review comments

@BuckarooBanzay BuckarooBanzay Awaiting requested review from BuckarooBanzay

Assignees

@wsor4035 wsor4035

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix all warnings make homedecor game agnostic
5 participants
@wsor4035 @sfence @fluxionary @S-S-X @Lazerbeak12345