Skip to content

Commit

Permalink
CSM: Remove screenshot API
Browse files Browse the repository at this point in the history 
Reverted from commit 19960e2
(* [CSM] add screenshot api lua)
  • Loading branch information
@red-001 @paramat
red-001 authored and paramat committed Jan 23, 2018
1 parent d6050be commit 0425c6b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
2 changes: 0 additions & 2 deletions doc/client_lua_api.txt
View file
Expand Up @@ -763,8 +763,6 @@ Call these functions only at load time!
* `minetest.disconnect()`
* Disconnect from the server and exit to main menu.
* Returns `false` if the client is already disconnecting otherwise returns `true`.
* `minetest.take_screenshot()`
* Take a screenshot.
* `minetest.get_server_info()`
* Returns [server info](#server-info).
* `minetest.send_respawn()`
Expand Down
8 changes: 0 additions & 8 deletions src/script/lua_api/l_client.cpp
View file
Expand Up @@ -330,13 +330,6 @@ int ModApiClient::l_get_node_def(lua_State *L)
return 1;
}

int ModApiClient::l_take_screenshot(lua_State *L)
{
Client *client = getClient(L);
client->makeScreenshot();
return 0;
}

int ModApiClient::l_get_privilege_list(lua_State *L)
{
const Client *client = getClient(L);
Expand Down Expand Up @@ -377,7 +370,6 @@ void ModApiClient::Initialize(lua_State *L, int top)
API_FCT(get_server_info);
API_FCT(get_item_def);
API_FCT(get_node_def);
API_FCT(take_screenshot);
API_FCT(get_privilege_list);
API_FCT(get_builtin_path);
API_FCT(get_language);
Expand Down
3 changes: 0 additions & 3 deletions src/script/lua_api/l_client.h
View file
Expand Up @@ -87,9 +87,6 @@ class ModApiClient : public ModApiBase
// get_node_def(nodename)
static int l_get_node_def(lua_State *L);

// take_screenshot()
static int l_take_screenshot(lua_State *L);

// get_privilege_list()
static int l_get_privilege_list(lua_State *L);

Expand Down

4 comments on commit 0425c6b

@oilboi
Copy link
Contributor

@oilboi oilboi commented on 0425c6b Jul 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@paramat
Copy link
Contributor

@paramat paramat commented on 0425c6b Jul 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #5674 #6932 for the danger of this.
Was removed by red-001 who was one of the CSM developers.

@oilboi
Copy link
Contributor

@oilboi oilboi commented on 0425c6b Jul 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read that part, a simple screenshots limit can be coded in because I can fill the hard drive myself on my 32GB flash drive with relative ease

@paramat
Copy link
Contributor

@paramat paramat commented on 0425c6b Jul 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait until SSCSM is complete before adding even more low-priority client-provided CSM features, which just makes SSCSM more difficult to complete.
Time and effort should go towards completing SSCSM instead of anything else in CSM.
One of the mistakes made when CSM was being developed was that the CSM devs kept adding low-priority client-provided CSM features instead of using that time to work on the actual intended feature of SSCSM.

Please sign in to comment.