Fix logic in porting::attachOrCreateConsole()

No functional change but now the comment is actually correct.
minetest · Jan 6, 2024 · 6550bc2 · 6550bc2
1 parent e04f618
commit 6550bc2
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/porting.cpp b/src/porting.cpp
@@ -737,12 +737,14 @@ void osSpecificInit()
 void attachOrCreateConsole()
 {
 #ifdef _WIN32
-	static bool consoleAllocated = false;
-	const bool redirected = (_fileno(stdout) == -2 || _fileno(stdout) == -1); // If output is redirected to e.g a file
-	if (!consoleAllocated && redirected && (AttachConsole(ATTACH_PARENT_PROCESS) || AllocConsole())) {
-		freopen("CONOUT$", "w", stdout);
-		freopen("CONOUT$", "w", stderr);
-		consoleAllocated = true;
+	static bool once = false;
+	const bool redirected = _fileno(stdout) >= 0; // If output is redirected to e.g a file
+	if (!once && !redirected) {
+		if (AttachConsole(ATTACH_PARENT_PROCESS) || AllocConsole()) {
+			freopen("CONOUT$", "w", stdout);
+			freopen("CONOUT$", "w", stderr);
+		}
+		once = true;
 	}
 #endif
 }